Re: commit head: bidi related performance fix in fl_BlockLayout::_doInsertTextSpan()

From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Sun Jul 28 2002 - 09:58:08 EDT

  • Next message: j.m.maurer: "Commit (HEAD): Hash Downloader Port"

    Hi Hub,

    > Can that optimization be applied to STABLE as well ? Gaining some
    > speed for the next release would not be a bad thing.

    the changes inside fl_BlockLayout::_doInsertTextSpan() can be
    carried over to stable without hesitation (the bidi build only, of
    course).

    I have also commented out a couple of calls to _lookupProperties(),
    one in fl_BlockLayout::formatLocal(), and one in
    fl_BlockLayout::redrawUpdate(). Both of these should not be there
    and are very performance-costly. Whether they were there to cover
    some other bug I am not 100% certain, but I would do this in stable
    as well, as this is simple to revert if worse comes to worst.

    Tomas

    This archive was generated by hypermail 2.1.4 : Sun Jul 28 2002 - 10:06:48 EDT