Re: uninitialized variable read

• Previous message: Patrick Lam: "commit: endnote style"
• In reply to: Patrick Lam: "uninitialized variable read"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hi Pat,

> valgrind complains about this fragment in fv_View.cpp (around line
> 5785)
>
> fp_Run* pRun = pBlock->findPointCoords(pos, m_bPointEOL, xPoint,
> yPoint, xPoint2, yPoint2, iPointHeight, bDirection);
>
> //
> // Detect if we have no Lines at the curren tpoint and bail out.
> //
> if(iPointHeight == 0)
> {
> return NULL;
> }
>
> because iPointHeight isn't necessarily initialized by findPointCoords.
> I don't actually know what you are trying to do here, but this isn't
> it.

It is not my code, but if you look at the implementation of
findPointCoords, you will see that if the run found is not on a line,
height is set to 0. What should be done though in the fv_View
code, is to test that we have found the run first.

Tomas

• Next message: Martin Sevior: "Re: help: endnote undo crash"
• Previous message: Patrick Lam: "commit: endnote style"
• In reply to: Patrick Lam: "uninitialized variable read"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Tue May 28 2002 - 05:05:57 EDT