Re: commit: another endnote undo fix

From: sam th (sam@uchicago.edu)
Date: Thu May 30 2002 - 10:54:20 EDT

  • Next message: Paul Rohr: "FAQ -- why were these lines changed in the source code?"

    On Thu, 2002-05-30 at 00:58, Patrick Lam wrote:

    > I found this mysteriously commented code in fl_SectionLayout:
    >
    > @@ -1579,11 +1605,11 @@
    > m_pLayout->removeSection(this);
    > pPrevSL->format();
    >
    > -// FV_View* pView = m_pLayout->getView();
    > -// if (pView)
    > -// {
    > -// pView->_setPoint(pcrx->getPosition());
    > -// }
    > + FV_View* pView = m_pLayout->getView();
    > + if (pView)
    > + {
    > + pView->_setPoint(pcrx->getPosition());
    > + }
    >
    > The key to fixing this bug was enabling this code; anyone have any
    > idea why it was commented?

    Well, I don't know why, but it was commented out on March 12-13, 2001 by
    Martin, and before that, it was written by Eric in 1999.

    A brief search of the mail archives points to this:
    http://www.abisource.com/mailinglists/abiword-dev/01/March/0676.html

    You'd have to ask Martin for more info than that. 

    -- 
sam th						OpenPGP Key: CABD33FC

    "Life is polynomial time." -- Laszlo Babai

    This archive was generated by hypermail 2.1.4 : Thu May 30 2002 - 10:59:40 EDT