Re: commit: another endnote undo fix

• Previous message: Hubert Figuiere: "Release 1.0.2 !"
• In reply to: Martin Sevior: "Re: commit: another endnote undo fix"
• Next in thread: Paul Rohr: "FAQ -- why were these lines changed in the source code?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

New Document
Edit->Insert Header
type 'help' in said header
undo
crash

#6 0x081efd2a in fp_Run::getBlockOffset (this=0x0)
    at ../../../../../abi/src/text/fmt/xp/fp_Run.h:163
#7 0x081f98c9 in FV_View::_charMotion (this=0x869ca50, bForward=true,
    countChars=0)
    at ../../../../../abi/src/text/fmt/xp/fv_View_protected.cpp:2913
#8 0x081f1402 in FV_View::cmdUndo (this=0x869ca50, count=1)
    at ../../../../../abi/src/text/fmt/xp/fv_View_cmd.cpp:722
#9 0x080e2f0d in ap_EditMethods::undo (pAV_View=0x869ca50)
    at ../../../../../abi/src/wp/ap/xp/ap_EditMethods.cpp:2247

Just FYI,
Dom

On Thu, 2002-05-30 at 20:00, Martin Sevior wrote:
> From my fading memory,
> That was commented out in order to get header/footers
> to not crash during either insertion or deletion or in order to get the
> insertion point back to where it should have been. I would test that
> headers/footers still work now. Inlcuding all the weird cases one might
> throw at them. It might be that the many improvements to header/footer
> code that have been made since that commit will keep things working
> anyway.
>
> Good Luck!
>
> Martin
>
>
> On Thu, 30 May 2002, sam th wrote:
>
> > On Thu, 2002-05-30 at 00:58, Patrick Lam wrote:
> >
> > > I found this mysteriously commented code in fl_SectionLayout:
> > >
> > > @@ -1579,11 +1605,11 @@
> > > m_pLayout->removeSection(this);
> > > pPrevSL->format();
> > >
> > > -// FV_View* pView = m_pLayout->getView();
> > > -// if (pView)
> > > -// {
> > > -// pView->_setPoint(pcrx->getPosition());
> > > -// }
> > > + FV_View* pView = m_pLayout->getView();
> > > + if (pView)
> > > + {
> > > + pView->_setPoint(pcrx->getPosition());
> > > + }
> > >
> > > The key to fixing this bug was enabling this code; anyone have any
> > > idea why it was commented?
> >
> > Well, I don't know why, but it was commented out on March 12-13, 2001 by
> > Martin, and before that, it was written by Eric in 1999.
> >
> > A brief search of the mail archives points to this:
> > http://www.abisource.com/mailinglists/abiword-dev/01/March/0676.html
> >
> > You'd have to ask Martin for more info than that.
> > --
> > sam th OpenPGP Key: CABD33FC
> >
> > "Life is polynomial time." -- Laszlo Babai
> >
>

• application/pgp-signature attachment: This is a digitally signed message part

• Next message: James Ogley: "Re: Release 1.0.2 !"
• Previous message: Hubert Figuiere: "Release 1.0.2 !"
• In reply to: Martin Sevior: "Re: commit: another endnote undo fix"
• Next in thread: Paul Rohr: "FAQ -- why were these lines changed in the source code?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Fri May 31 2002 - 09:34:34 EDT