Re: commit: footnote work

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Wed Jul 31 2002 - 15:07:21 EDT

  • Next message: Rui Miguel Seabra: "Re: abiword translation (fwd)"

    On Wed, Jul 31, 2002 at 01:58:59PM +0200, Hubert Figuiere wrote:
    >
    > > Insert | Endnote crashes Abi now, but the layouts get properly placed
    > > in the layout hierarchy. I need to make the containers, though; this
    > > happens in fb_ColumnBreaker.cpp. That's the next thing I'm going to
    > > work on (in my copious spare time.)
    >
    > Loading file is foobared, once again.

    fix document loading bug due to poor nomenclature
    Checking in src/text/fmt/xp/fb_ColumnBreaker.cpp;
    /cvsroot/abi/src/text/fmt/xp/fb_ColumnBreaker.cpp,v <-- fb_ColumnBreaker.cpp
    new revision: 1.11; previous revision: 1.10

    The problem here was rather bad. We had two variables, pCurContainer
    and pCurrentContainer. I thought that pCurrentContainer was just badly
    named to take up more screen real estate, so I renamed it to pCurContainer,
    not knowing that there was another pCurContainer used elsewhere! Argh!

    pat
    tagline: confusingly similarly named variables are bad

    This archive was generated by hypermail 2.1.4 : Wed Jul 31 2002 - 15:14:05 EDT